Do not verify lengths in propWithModel
#91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnbastiaan
force-pushed
the
fix81
branch
2 times, most recently
from
5b3cf68 to
4a3dfbf
Compare
lmbollen
approved these changes
Jul 29, 2024
Comment on lines
+65
to
+74
| smallInt :: H.Range Int | ||
| smallInt = Range.linear 0 10 | ||
|
|
||
| genSmallInt :: H.Gen Int | ||
| genSmallInt = | ||
| Gen.frequency | ||
| [ (90, Gen.integral smallInt) | ||
| , (10, Gen.constant (Range.lowerBound 99 smallInt)) | ||
| ] | ||
|
|
There was a problem hiding this comment.
Consecutive stalling up to only 10 cycles is a very low default.
This should be configurable or derived from configuration? Could you make an issue and point to it here?
martijnbastiaan
commented
Jul 29, 2024
The input length is not always equal to the output length, nor even predictable. Furthermore, some properties might not be interested in the length in the first place. Fixes #81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input length is not always equal to the output length, nor even predictable. Furthermore, some properties might not be interested in the length in the first place.
Fixes #81